Skip to content

Reorganizing complete solution to docker-image.md #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ncsokas
Copy link

@ncsokas ncsokas commented Jul 8, 2025

This pull request refactors the GitHub Actions workflow file docker-image.yaml to improve structure, readability, and functionality.

  • Split the workflow into four distinct jobs: lint, build, test, and publish, each with clear responsibilities.
  • Added dependencies between jobs to ensure proper execution order (e.g., test depends on build, and publish depends on both test and lint).
  • Added explicit chmod +x commands to replace the bash step as making the script explicitly executable before running is recommended.

@ncsokas ncsokas requested review from moller2866 and amrutashety July 8, 2025 16:07
Copy link

@amrutashety amrutashety left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants